[webkit-reviews] review granted: [Bug 22879] Qt WebKit does not build on Windows with MSVC : [Attachment 26051] Fix Windows buid with MSVC 2005

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 16 10:59:01 PST 2008


Adam Roben (aroben) <aroben at apple.com> has granted Yael
<yael.aharon at nokia.com>'s request for review:
Bug 22879: Qt WebKit does not build on Windows with MSVC
https://bugs.webkit.org/show_bug.cgi?id=22879

Attachment 26051: Fix Windows buid with MSVC 2005
https://bugs.webkit.org/attachment.cgi?id=26051&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +++ WebCore/platform/win/SystemTimeWin.cpp	(working copy)
> @@ -32,7 +32,11 @@
>  #if COMPILER(MINGW)
>  #include <float.h>
>  #define FLOAT_MAX FLT_MAX
> +#else
> +#if PLATFORM(QT)
> +#include <float.h>
>  #endif
> +#endif

I think using #elif would be better than introducing an extra level of nesting
here.

r=me


More information about the webkit-reviews mailing list