[webkit-reviews] review requested: [Bug 22429] document.styleSheets collection ignores media=presentation : [Attachment 26031] Different approach

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 15 13:52:47 PST 2008

Rob Buis <rwlbuis at gmail.com> has asked	for review:
Bug 22429: document.styleSheets collection ignores media=presentation

Attachment 26031: Different approach

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
This patch simply loads all sheets regardless of the media attribute. However
addRulesFromSheet still blocks the rules in this sheet. The testcase is a start
but should also verify that the sheet gets loaded but does not apply for media
attributes other than all, screen and print. I am not sure yet whether those
should be multipe testcases. It is a bit hard for me to judge efficiency,
obviously it is slower when there are sheets with media other than all, screen
or print but I think that is uncommon. A more efficient solution would be to
make ::styleSheets get all sheets on demand but I guess that would involve it
waiting for all sheets to load before returning.


More information about the webkit-reviews mailing list