[webkit-reviews] review requested: [Bug 22847] Geolocation PositionOptions cannot be an arbitrary object : [Attachment 26027] Updated patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has asked  for review:
Bug 22847: Geolocation PositionOptions cannot be an arbitrary object
https://bugs.webkit.org/show_bug.cgi?id=22847

Attachment 26027: Updated patch
https://bugs.webkit.org/attachment.cgi?id=26027&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
Greg, this is an updated version of the patch which hopefully addresses Darin's
comments.  It would great if you could test this with some malformed
PositionOptions to make sure all is well.

Example of malformed PositionOptions include:

// Exception being thrown
var o = { get timeout() { throw 1; } }

// Overflow (note UINT_MAX doesn't exist in JS, so you will have to fill it in
yourself)
var o = { timeout: UINT_MAX + 1; }