[webkit-reviews] review requested: [Bug 22847] Geolocation PositionOptions cannot be an arbitrary object : [Attachment 26027] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 15 12:08:30 PST 2008

Sam Weinig <sam at webkit.org> has asked  for review:
Bug 22847: Geolocation PositionOptions cannot be an arbitrary object

Attachment 26027: Updated patch

------- Additional Comments from Sam Weinig <sam at webkit.org>
Greg, this is an updated version of the patch which hopefully addresses Darin's
comments.  It would great if you could test this with some malformed
PositionOptions to make sure all is well.

Example of malformed PositionOptions include:

// Exception being thrown
var o = { get timeout() { throw 1; } }

// Overflow (note UINT_MAX doesn't exist in JS, so you will have to fill it in
var o = { timeout: UINT_MAX + 1; }

More information about the webkit-reviews mailing list