[webkit-reviews] review granted: [Bug 22562] REGRESSION (r37971): events not firing after going back in back/forward cache : [Attachment 26024] Revised proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 15 05:59:40 PST 2008

Darin Adler <darin at apple.com> has granted Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>'s request for review:
Bug 22562: REGRESSION (r37971): events not firing after going back in
back/forward cache

Attachment 26024: Revised proposed patch

------- Additional Comments from Darin Adler <darin at apple.com>
The naming isn't quite right here.

The "platform" calls are part of the "back end" of the ScriptController object,
not designed to be called directly. So the right way to do this would be to
have a new function, platform independent, that calls
updatePlatformScriptObjects. That would be one more level of function call, but
it would preserve the design.

I also think the words clear and update here are terribly confusing. That name
is left over from when we had a Window object and we called "clear" to clear
state out of the Window object and get it ready for re-use. Now the "update"
function is used to connect script objects to a new DOM window, and yet the
name doesn't say that.

I'm going to say review+ because I like how this works, but I really don't like
the names.


More information about the webkit-reviews mailing list