[webkit-reviews] review cancelled: [Bug 17425] eliminate DeprecatedPtrList : [Attachment 26012] patch for part of this

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 14 18:40:20 PST 2008


Darin Adler <darin at apple.com> has cancelled 's request for review:
Bug 17425: eliminate DeprecatedPtrList
https://bugs.webkit.org/show_bug.cgi?id=17425

Attachment 26012: patch for part of this
https://bugs.webkit.org/attachment.cgi?id=26012&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Clearing review flag since I landed this as
http://trac.webkit.org/changeset/39296 and took care of (2), (4), (5), and (6)
above. Here's what remains:

    1) CSSRuleList::m_lstCSSRules. This can almost certainly be a Vector. But
things are little tangled in the CSS classes at the moment and there is some
other improvement that can be made too.

    3) RenderBlock::m_floatingObjects. Probably simple to change this to a
ListHashSet as m_positionedObjects is. But it might be even more efficient if
the objects didn't each have to be in a separate memory block.

The old patch attached to this bug includes has a cut at fixing both of these
issues.


More information about the webkit-reviews mailing list