[webkit-reviews] review requested: [Bug 22429] document.styleSheets collection ognores media=presentation : [Attachment 26014] First attempt
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Dec 14 12:48:08 PST 2008
Rob Buis <rwlbuis at gmail.com> has asked for review:
Bug 22429: document.styleSheets collection ognores media=presentation
https://bugs.webkit.org/show_bug.cgi?id=22429
Attachment 26014: First attempt
https://bugs.webkit.org/attachment.cgi?id=26014&action=review
------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
I think it is not just media="projection", since with any media attribute I try
the sheet ends up in the styleSheets collection. This patch makes an empty
sheet entry to make the styleSheets collection correct. Since they are empty
there are no rules that contribute to the style collection. Obviously there are
speed regressions when encountering media other than all, screen or print, but
I assume these are uncommon. If this is the right approach I'll make some
testcase(s).
Cheers,
Rob.
More information about the webkit-reviews
mailing list