[webkit-reviews] review requested: [Bug 20952] QtWebKit needs the old history pull model for API Compability : [Attachment 26011] Add the GlobalHistory back for QtWebKit.

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has asked  for review:
Bug 20952: QtWebKit needs the old history pull model for API Compability
https://bugs.webkit.org/show_bug.cgi?id=20952

Attachment 26011: Add the GlobalHistory back for QtWebKit.
https://bugs.webkit.org/attachment.cgi?id=26011&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Another patch working on the LinkHash and CSSStyleSelector:
  - Add a method to LinkHash to resolve the URL. In contrast to the previous
attempt the API is not too ugly

  - I'm aware how ugly this is, specially of having a #ifdef in the
CSSStyleSelector and having a WebKit type there. For Qt4.5 it is needed though.
Maybe it is time to add a "bridge" for QtWebKit as well and some hints to
reduce the ugliness are much appreciated.

  - The limited tests of Gtk+ still pass and a test case for QtWebKit is added