[webkit-reviews] review granted: [Bug 22848] Port the remainder of the JIT to use the MacroAssembler... : [Attachment 26007] The patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 13 15:49:46 PST 2008


Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 22848: Port the remainder of the JIT to use the MacroAssembler...
https://bugs.webkit.org/show_bug.cgi?id=22848

Attachment 26007: The patch
https://bugs.webkit.org/attachment.cgi?id=26007&action=review

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
You accidentally added trailing whitespace to MacroAssembler.h:183.

The name 'mips' should be capitalized.

The members of JITCodeRef should come after the constructors and should not
have the m_ prefix.

Other than that, r=me.


More information about the webkit-reviews mailing list