[webkit-reviews] review requested: [Bug 22824] REGRESSION (r39206): 3 SVG pixel tests are failing on the Leopard pixel bot since r39206 : [Attachment 26002] Attempt to fix the regression
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Dec 13 12:47:56 PST 2008
Holger Freyther <zecke at selfish.org> has asked for review:
Bug 22824: REGRESSION (r39206): 3 SVG pixel tests are failing on the Leopard
pixel bot since r39206
https://bugs.webkit.org/show_bug.cgi?id=22824
Attachment 26002: Attempt to fix the regression
https://bugs.webkit.org/attachment.cgi?id=26002&action=review
------- Additional Comments from Holger Freyther <zecke at selfish.org>
Ouch. The patch was changed to use USE(...) instead of ENABLE(...) and this one
item was not changed. When looking at the patch I didn't see the wrong #if. I
think the other part of the patch is right. I'm currently not on OSX and I'm
not able to run the pixel tests.
The change from:
if(canUse)
simple
else
complex
}
to
if (canUse)
return simple;
return complex
}
looks okay and is matching other parts of the code...
More information about the webkit-reviews
mailing list