[webkit-reviews] review granted: [Bug 21807] Add the ability for embedders to use Google-URL without changing shared headers : [Attachment 25985] Patch v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 12 13:15:27 PST 2008
Darin Adler <darin at apple.com> has granted Brett Wilson (Google)
<brettw at chromium.org>'s request for review:
Bug 21807: Add the ability for embedders to use Google-URL without changing
shared headers
https://bugs.webkit.org/show_bug.cgi?id=21807
Attachment 25985: Patch v2
https://bugs.webkit.org/attachment.cgi?id=25985&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
r=me
> +#if !USE(GOOGLEURL)
> +// Inline versions of some non-GoogleURL functions so we can get inlining
> +// without having to have a lot of ugly ifdefs in the class definition.
Incredibly minor comment someone could possibly tweak while landing: I'd like
to see a blank line here to better match the blank line before #endif.
More information about the webkit-reviews
mailing list