[webkit-reviews] review requested: [Bug 22807] Cygwin/X WebKit/Gtk port : [Attachment 25971] PLATFORM(CYGWIN) patch, take two

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 11 17:58:43 PST 2008


Cygwin Ports <yselkowitz at users.sourceforge.net> has asked  for review:
Bug 22807: Cygwin/X WebKit/Gtk port
https://bugs.webkit.org/show_bug.cgi?id=22807

Attachment 25971: PLATFORM(CYGWIN) patch, take two
https://bugs.webkit.org/attachment.cgi?id=25971&action=review

------- Additional Comments from Cygwin Ports
<yselkowitz at users.sourceforge.net>
Last patch was incorrect, this works (supersedes patches in comment 2 and
comment 5):

* JavaScriptCore/wtf/Platform.h: Define PLATFORM(CYGWIN) and PLATFORM(UNIX) on
Cygwin.
* JavaScriptCore/API/JSStringRef.h: Fix JSChar typedef on Cygwin.
* JavaScriptCore/runtime/DateMath.h: No tm_gmtoff on Cygwin.
* WebCore/plugins/PluginDatabase.cpp: Cygwin plugins have .dll extension.
* WebKitTools/DumpRenderTree/DumpRenderTree.h: No std::wstring on Cygwin.


More information about the webkit-reviews mailing list