[webkit-reviews] review granted: [Bug 22798] Unitialized struct field in SVGFont.cpp : [Attachment 25952] Patch to fix

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dave Moore <davemoore at google.com>'s
request for review:
Bug 22798: Unitialized struct field in SVGFont.cpp
https://bugs.webkit.org/show_bug.cgi?id=22798

Attachment 25952: Patch to fix
https://bugs.webkit.org/attachment.cgi?id=25952&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Just nits:
 1 2008-12-11  davemoore  <davemoore at google.com>

Should be:
 1 2008-12-11  David Moore  <davemoore at google.com>

(See my email on changelog entries sent to chrome-team last week.)

WARNING: NO TEST CASES ADDED OR CHANGED

can be removed and replaced when an explanation as to why it's untestable.

 5	Fixed https://bugs.webkit.org/show_bug.cgi?id=22798

Looks like a tab (or maybe just bad indentation)

Looks fine.  We could also have fixed this by adding a constructor to
SVGTextRunWalkerMeasuredLengthData (which would have possibly prevented future
such UMRs.


Marking r- for the nits.  Post another copy and I'll be happy to review and
land it for you.  Thanks for the fix!