[webkit-reviews] review granted: [Bug 22713] Confusing/repetitive onboard unicode sources : [Attachment 25819] Always check for icu-config first

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 10 14:48:16 PST 2008


Darin Adler <darin at apple.com> has granted Daniel Macks <dmacks at netspace.org>'s
request for review:
Bug 22713: Confusing/repetitive onboard unicode sources
https://bugs.webkit.org/show_bug.cgi?id=22713

Attachment 25819: Always check for icu-config first
https://bugs.webkit.org/attachment.cgi?id=25819&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	Default to use external libicu-config if avail on all platforms.
> +
> +	https://bugs.webkit.org/show_bug.cgi?id=22713

Tabs in ChangeLog. Please don't use tabs in patches you submit to WebKit.

Change seems fine. r=me


More information about the webkit-reviews mailing list