[webkit-reviews] review granted: [Bug 22795] favicons should be saved to webarchives : [Attachment 25925] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 10 14:25:54 PST 2008

Darin Adler <darin at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 22795: favicons should be saved to webarchives

Attachment 25925: Patch v1

------- Additional Comments from Darin Adler <darin at apple.com>
> +	       RefPtr<SharedBuffer> data =
iconDatabase()->iconForPageURL(responseURL, IntSize(16, 16))->data();
> +	       RefPtr<ArchiveResource> resource = ArchiveResource::create(data,
KURL(iconURL), "image/x-icon", "", "");

This should be data.release().


More information about the webkit-reviews mailing list