[webkit-reviews] review granted: [Bug 22665] Remove setCreatedByParser(bool) from the few elements that use it : [Attachment 25896] Third and last part : remove it from frame and iframe

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Julien Chaffraix
<jchaffraix at pleyo.com>'s request for review:
Bug 22665: Remove setCreatedByParser(bool) from the few elements that use it
https://bugs.webkit.org/show_bug.cgi?id=22665

Attachment 25896: Third and last part : remove it from frame and iframe
https://bugs.webkit.org/attachment.cgi?id=25896&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
>  HTMLPlugInElement::HTMLPlugInElement(const QualifiedName& tagName, Document*
doc)
> -    : HTMLFrameOwnerElement(tagName, doc)
> +    : HTMLFrameOwnerElement(tagName, doc, false)
>  #if ENABLE(NETSCAPE_PLUGIN_API)
>      , m_NPObject(0)
>  #endif

I think you stumbled on a bug here.

You should comment about the fact that this is strange.

You should consider filing a bug report.

You consider thinking about what the symptom of the bug would be. What does
HTMLFrameOwnerElement do differently when created by the parser? And then
construct a test case. And then fix the bug.

r=me