[webkit-reviews] review granted: [Bug 22679] [GTK] Function Keys (F1 to F12) are not mapped : [Attachment 25875] Patch for F1-F12 key mappings for WebKit GTK port(Eric Suggestion)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 9 04:32:39 PST 2008


Holger Freyther <zecke at selfish.org> has granted Srinivas Rao M Hamse
<msrinirao at gmail.com>'s request for review:
Bug 22679: [GTK] Function Keys (F1 to  F12) are not mapped
https://bugs.webkit.org/show_bug.cgi?id=22679

Attachment 25875: Patch for F1-F12 key mappings for  WebKit GTK port(Eric
Suggestion)
https://bugs.webkit.org/attachment.cgi?id=25875&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Remove the conflict marker when landing the patch. Let us use this
implementation:

  - It is not using C99/gccism
  - Everything else is using switch/case and adding a if feels misplaced.


More information about the webkit-reviews mailing list