[webkit-reviews] review denied: [Bug 21820] Unable to enter the Tamil UNICODE Characters via Thamizha Phonetic IME : [Attachment 25878] nineth proposed fix

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Hironori Bono
<hbono at chromium.org>'s request for review:
Bug 21820: Unable to enter the Tamil UNICODE Characters via Thamizha Phonetic
IME
https://bugs.webkit.org/show_bug.cgi?id=21820

Attachment 25878: nineth proposed fix
https://bugs.webkit.org/attachment.cgi?id=25878&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+	 Added test for verifying if a backspace key deletes only the last
character of a ligature which consists of
+	multiple Unicode characters.

There is a tab in ChangeLog here, please replace it with spaces.

These tests are not text-only, but the patch only includes text results. Please
use layoutTestController to make the tests text-only:
if (window.layoutTestController)
    layoutTestController.dumpAsText().

This patch works much better, but it breaks at least one existing layout test
for me: editing/deleting/delete-br-011.html. Does this happen on your machine?