[webkit-reviews] review granted: [Bug 22679] [GTK] Function Keys (F1 to F12) are not mapped : [Attachment 25769] Patch for F1-F12 key mappings for WebKit GTK port

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Srinivas Rao M Hamse
<msrinirao at gmail.com>'s request for review:
Bug 22679: [GTK] Function Keys (F1 to  F12) are not mapped
https://bugs.webkit.org/show_bug.cgi?id=22679

Attachment 25769: Patch for F1-F12 key mappings for  WebKit GTK port
https://bugs.webkit.org/attachment.cgi?id=25769&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks fine.  It would have been easy to write as an if depending on GDK_F1 to
GDK_F24 being in the same order.  Something like:

if (code >= GDK_F1 && code <= GDK_F24)
  return VK_F1 + (code - GDK_F1);

But it's also OK to have been explicit.