[webkit-reviews] review denied: [Bug 21445] on windows, we try to remove m_smallCapsFontData from the font cache, but we never added it there : [Attachment 24163] [1/1] Fix a bug where we try to release font data from the font cache when it

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 8 15:45:47 PST 2008


Eric Seidel <eric at webkit.org> has denied 's request for review:
Bug 21445: on windows, we try to remove m_smallCapsFontData from the font
cache, but we never added it there
https://bugs.webkit.org/show_bug.cgi?id=21445

Attachment 24163: [1/1] Fix a bug where we try to release font data from the
font cache when it
https://bugs.webkit.org/attachment.cgi?id=24163&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This really should have a layout test.	Marking r- due to lack of layout test. 
If you upload a patch with a layout test I'm happy to land.  Or, if you can
explain how this is untestable I'm happy to land.

(p.s. ideally ChangeLogs should have links to the bugzilla bug in them.  Also
in general you should replace "WARNING:" with either the location of the test
case or an explanation why it's not possible)


More information about the webkit-reviews mailing list