[webkit-reviews] review granted: [Bug 22580] canvas.setShadow should use platform-independent GraphicsContext API : [Attachment 25782] [1/1] Add a bool to GraphicsContext so that shadows can ignore
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 8 12:52:49 PST 2008
Eric Seidel <eric at webkit.org> has granted Tony Chang (Google)
<tony at chromium.org>'s request for review:
Bug 22580: canvas.setShadow should use platform-independent GraphicsContext API
https://bugs.webkit.org/show_bug.cgi?id=22580
Attachment 25782: [1/1] Add a bool to GraphicsContext so that shadows can
ignore
https://bugs.webkit.org/attachment.cgi?id=25782&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks good. I really need to add a float-enabled Color class to platform,
since with this patch, we only support 256 grays for shadows. Which is fine...
but still lame.
r+
More information about the webkit-reviews
mailing list