[webkit-reviews] review requested: [Bug 22717] Make CSS values use less memory : [Attachment 25832] share primitive value instances

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 7 15:12:54 PST 2008

Antti Koivisto <koivisto at iki.fi> has asked  for review:
Bug 22717: Make CSS values use less memory

Attachment 25832: share primitive value instances

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
A more stylish solution than sharing would be to turn CSSPrimitiveValue (or
CSSValues in general) into non-virtual, non-refcounted simple type with value
semantics. In practice these sharing tricks get similar memory benefits with
less need for refactoring.

This does not directly depend on the previous patch (as the parent field of
CSSValues is never used) thought it depends on it conceptually to facilitate

More information about the webkit-reviews mailing list