[webkit-reviews] review denied: [Bug 22696] Canvas without pixel tests : [Attachment 25793] pixel test replacement

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 7 01:45:50 PST 2008

Oliver Hunt <oliver at apple.com> has denied Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 22696: Canvas without pixel tests

Attachment 25793: pixel test replacement

------- Additional Comments from Oliver Hunt <oliver at apple.com>
My concern lies primarily with the under sampling -- i think that for identity,
multiply, and skewed transform checks the pixel tests actually make sense --
the text based canvas tests are used to test rendering behaviour of specific
features simply by drawing simple rects, and sampling multiple points inside
and outside those rects (because we're testing positioning behaviour or making
sure certain operations are ignored so only a limited number of samples are

For things like transform-skew we really need to make sure that the shape is
correct, hence pixel tests are reasonable.

More information about the webkit-reviews mailing list