[webkit-reviews] review requested: [Bug 22631] Streamline Console.cpp, abstract out the use of JSC::ExecState and JSC::ArgList by introducing ScriptCallFrame and ScriptStackTrace abstractions : [Attachment 25825] ScriptStackTrace and ScriptCallFrame v2

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has asked Timothy Hatcher
<timothy at hatcher.name> for review:
Bug 22631: Streamline Console.cpp, abstract out the use of JSC::ExecState and
JSC::ArgList by introducing ScriptCallFrame and ScriptStackTrace abstractions
https://bugs.webkit.org/show_bug.cgi?id=22631

Attachment 25825: ScriptStackTrace and ScriptCallFrame v2
https://bugs.webkit.org/attachment.cgi?id=25825&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
I reworked this a little bit to change the relationship and move methods around
as follows:

* Now, the umbrella instance is ScriptStackTrace, which just has methods to
access ScriptCallFrames and ScriptState

* argumentAt, argumentCount, functionName, lineNumber, etc. are now all at
ScriptCallFrame.

* first ScriptCallFrame is created differently, because it is the only frame
that has line number and arguments information at the moment.

Thanks for suggesting this, Timothy. This does look a bit cleaner.