[webkit-reviews] review requested: [Bug 18205] DOMNode objects are garbage collected although there are strong references : [Attachment 25809] Second attempt to fix the resurrection bug for DOM wrapper objects

[bugzilla-daemon at webkit.org]

Kai Brüning <kai at granus.net> has asked	for review:
Bug 18205: DOMNode objects are garbage collected although there are strong
references
https://bugs.webkit.org/show_bug.cgi?id=18205

Attachment 25809: Second attempt to fix the resurrection bug for DOM wrapper
objects 
https://bugs.webkit.org/attachment.cgi?id=25809&action=review

------- Additional Comments from Kai Brüning <kai at granus.net>
Oops, sorry, I overlooked the Tiger-requirement.

I changed the implementation mostly as suggested.

What I do not understand is the suggestion about using BUILDING_ON_TIGER,
because this is a compile time switch and I’d say we need a runtime check to
create a single binary which works both under Tiger and Leopard. I implemented
such a runtime check, but wasn’t able to test it under Tiger because I am
lacking a suitable Tiger system (if only Apple wouldn’t be so restrictive about
virtualizing Mac OS X...).

I do not know whether my runtime check is the prefered method for such checks
in WebKit. Please advice.