[webkit-reviews] review requested: [Bug 21534] Radio button without name cannot be selected : [Attachment 25804] Possible patch for issue 21534

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 5 17:50:46 PST 2008


Glenn Wilson <gwilson at google.com> has asked  for review:
Bug 21534: Radio button without name cannot be selected
https://bugs.webkit.org/show_bug.cgi?id=21534

Attachment 25804: Possible patch for issue 21534
https://bugs.webkit.org/attachment.cgi?id=25804&action=review

------- Additional Comments from Glenn Wilson <gwilson at google.com>
IE6 (and an earlier version of 7) had a quirk where they would not allow
unnamed radio buttons to be selected.  WebKit mimicked this behavior.  However,
now IE7 and 8 do allow the user to select unnamed radio buttons.

This patch modifies HTMLInputElement's behavior to treat named and unnamed
radio buttons the same.  That is, this patch removes the checks that explicitly
look for unnamed radios.

The only check that remains is in HTMLFormElement, which checks for radio
button naming for grouping.  Unnamed radio buttons should not be grouped and
can be selected ("on") simultaneously.	IE and FF behave this way, so I didn't
modify this behavior.

This patch brings WebKit's behavior to parity with FF/IE7&8.


More information about the webkit-reviews mailing list