[webkit-reviews] review granted: [Bug 22697] Move JIT::compileOpStrictEq to MacroAssembler interface. : [Attachment 25796] The patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 5 15:52:20 PST 2008
Geoffrey Garen <ggaren at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 22697: Move JIT::compileOpStrictEq to MacroAssembler interface.
https://bugs.webkit.org/show_bug.cgi?id=22697
Attachment 25796: The patch
https://bugs.webkit.org/attachment.cgi?id=25796&action=review
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
> 7 The rewrite also looks like a small (<1%) performance progression.
Should mention what test you ran.
> + // Check that bot are immediates, if so check if they're equal
Typo: "both."
r=me
More information about the webkit-reviews
mailing list