[webkit-reviews] review requested: [Bug 22301] dispatchDidFinishDocumentLoad and window.onload order are inconsistent : [Attachment 25790] New patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 5 14:42:41 PST 2008

Aaron Boodman <aa at chromium.org> has asked  for review:
Bug 22301: dispatchDidFinishDocumentLoad and window.onload order are

Attachment 25790: New patch

------- Additional Comments from Aaron Boodman <aa at chromium.org>
Sorry, the last patch was incorrect. Also, sorry about the tabs, I am still
getting used to working on a mac.

I worried about rebaselining these tests at first but I think I convinced
myself it is the right thing to do.

The removed lines from the layout tests were getting printed out by
DumpRenderTree's FrameLoaderDelegate implementation inside

Before my change FrameLoader would sometimes call
didFinishDocumentLoadForFrame() after firing window.onload events. Since this
layout test is doing its work in window.onload, this would result in some
remnants of the test (in this case, the fact that it set a window.onunload
hander) showing up in the output. I don't think this is relevant to what these
tests are attempting to prove, though.

But I'm new to WebKit so please let me know if I'm wrong.

More information about the webkit-reviews mailing list