[webkit-reviews] review requested: [Bug 22580] canvas.setShadow should use platform-independent GraphicsContext API : [Attachment 25782] [1/1] Add a bool to GraphicsContext so that shadows can ignore

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 5 12:19:29 PST 2008


Tony Chang (Google) <tony at chromium.org> has asked  for review:
Bug 22580: canvas.setShadow should use platform-independent GraphicsContext API
https://bugs.webkit.org/show_bug.cgi?id=22580

Attachment 25782: [1/1] Add a bool to GraphicsContext so that shadows can
ignore
https://bugs.webkit.org/attachment.cgi?id=25782&action=review

------- Additional Comments from Tony Chang (Google) <tony at chromium.org>
transformations.  This is needed by HTML canvas element
where the spec says shadows are applied w/o transformations.
---
 WebCore/ChangeLog				    |	23 ++++++
 WebCore/html/CanvasRenderingContext2D.cpp	    |	76 +++++---------------
 WebCore/html/HTMLCanvasElement.cpp		    |	 2 +
 WebCore/platform/graphics/GraphicsContext.cpp	    |	 5 ++
 WebCore/platform/graphics/GraphicsContext.h	    |	 1 +
 WebCore/platform/graphics/GraphicsContextPrivate.h |	 3 +
 WebCore/platform/graphics/cg/GraphicsContextCG.cpp |	29 +++++---
 7 files changed, 71 insertions(+), 68 deletions(-)


More information about the webkit-reviews mailing list