[webkit-reviews] review denied: [Bug 18205] DOMNode objects are garbage collected although there are strong references : [Attachment 24913] Fix for the resurrection bug of DOM wrapper objects

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Kai Brüning <kai at granus.net>'s request
for review:
Bug 18205: DOMNode objects are garbage collected although there are strong
references
https://bugs.webkit.org/show_bug.cgi?id=18205

Attachment 24913: Fix for the resurrection bug of DOM wrapper objects
https://bugs.webkit.org/attachment.cgi?id=24913&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
OK, I retract my earlier complaint.

The basic approach of using an NSMapTable seems fine.

I'm going to have to say review-, though, because this code uses things in
NSMapTable.h that are supported in Leopard and newer only, and we need code
that will also work in Tiger. I believe that we can do most of the work by
using the old map table API, the functions such as NSMapRemove, NSMapInsert and
NSMapGet. We'll only need to use the new API for creating the new map table and
we can use BUILDING_ON_TIGER to make a version that works on Tiger too.

Also, there are tabs in the ChangeLog. Please leave those out next time around.