[webkit-reviews] review granted: [Bug 18830] Assertion failure (using HashMap empty value) in svg/W3C-SVG-1.1/fonts-glyph-02-t.svg : [Attachment 25524] Fix the calculation for RTL text to stop reading random memory

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Holger Freyther <zecke at selfish.org>'s
request for review:
Bug 18830: Assertion failure (using HashMap empty value) in
svg/W3C-SVG-1.1/fonts-glyph-02-t.svg
https://bugs.webkit.org/show_bug.cgi?id=18830

Attachment 25524: Fix the calculation for RTL text to stop reading random
memory
https://bugs.webkit.org/attachment.cgi?id=25524&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	       const int extraCharsAvailable = length - textBox->end() + i - 1;


We don't use const for local variables in cases like this, and I don't think
it's good to start using it in some places but noth others.

r=me on this change despite all the caveats in the change log