[webkit-reviews] review denied: [Bug 22374] Need API to access favicons using the favicon URL. : [Attachment 25300] Implementation of the new required API

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Simon Hausmann <hausmann at webkit.org>'s
request for review:
Bug 22374: Need API to access favicons using the favicon URL.
https://bugs.webkit.org/show_bug.cgi?id=22374

Attachment 25300: Implementation of the new required API
https://bugs.webkit.org/attachment.cgi?id=25300&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
I'm not sure I understand the use of the term "API" here. This is the internal
interface between WebCore and WebKit. I don't see a patch adding API to any
platform's WebKit.

A patch that adds an unused function is not a good idea.

Further, there's too much copied and pasted code here -- this should not just
be a copy of iconForPageURL; instead it should be factored so the code is
shared appropriately.

Because of these two issues I'm going to say review- for this version of the
patch.