[webkit-reviews] review granted: [Bug 15671] [Transforms] The caret doesn't blink inside transformed content. : [Attachment 25209] Final patch, doesn't break arrow navigation
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 5 09:38:32 PST 2008
Dave Hyatt <hyatt at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 15671: [Transforms] The caret doesn't blink inside transformed content.
https://bugs.webkit.org/show_bug.cgi?id=15671
Attachment 25209: Final patch, doesn't break arrow navigation
https://bugs.webkit.org/attachment.cgi?id=25209&action=review
------- Additional Comments from Dave Hyatt <hyatt at apple.com>
+ // First compute a rect local to the rendere at the selection
start
Typo: you meant "renderer"
"// because it's m_frame is always 0."
it's should be its
"+ , m_beginMinWidth(0)
+ , m_endMinWidth(0)"
This seems irrelevant to the patch? Not that I'm complaining, just curious.
r=me
More information about the webkit-reviews
mailing list