[webkit-reviews] review denied: [Bug 22024] Assertion Failure: !m_singlePageGroup in Page::initGroup : [Attachment 24830] check if we have a group before adding a group profile to the window

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 5 09:34:50 PST 2008


Darin Adler <darin at apple.com> has denied Jan Alonzo <jmalonzo at gmail.com>'s
request for review:
Bug 22024: Assertion Failure: !m_singlePageGroup in Page::initGroup
https://bugs.webkit.org/show_bug.cgi?id=22024

Attachment 24830: check if we have a group before adding a group profile to the
window
https://bugs.webkit.org/attachment.cgi?id=24830&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
If this is a workaround for a GTK-specific bug, then I don't think it should be
added unconditionally for all platforms. There's nothing in the patch that
explains this.

And whether or not this is a workaround for a GTK-specific bug, then I'd like
to see the test case included with the bug fix in a single patch.

review- for now until this minor business is resolved.


More information about the webkit-reviews mailing list