[webkit-reviews] review granted: [Bug 22672] ASSERT(m_table) when xhr.onabort creates another xhr or calls setTimeout : [Attachment 25772] proposed fix

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 22672: ASSERT(m_table) when xhr.onabort creates another xhr or calls
setTimeout
https://bugs.webkit.org/show_bug.cgi?id=22672

Attachment 25772: proposed fix
https://bugs.webkit.org/attachment.cgi?id=25772&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 39023)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,36 @@
> +2008-12-05  Alexey Proskuryakov  <ap at webkit.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=22672
> +	   ASSERT(m_table) when xhr.onabort creates another xhr or calls
setTimeout
> +
> +	   Test: http/tests/xmlhttprequest/send-on-abort.html
> +
> +	   * dom/ScriptExecutionContext.cpp:
> +	   (WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
> +	   (WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
> +	   (WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
> +	   (WebCore::ScriptExecutionContext::stopActiveDOMObjects):
> +	   Add a comment explaining that ActiveDOMObject methods shouldn't
execute arbitrary JS.
> +
> +	   * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::stop): Don't
dispatch events. This
> +	   reverts a recent change that made the behavior slightly closer to
Firefox - but the
> +	   compatibility effect should be very minor if any, and Firefox itself
behaves inconsistently.
> +
> +2008-12-05  Alexey Proskuryakov  <ap at webkit.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * WebCore.xcodeproj/project.pbxproj:
> +	   * dom/ScriptExecutionContext.cpp:
> +	   (WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
> +	   (WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
> +	   (WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
> +	   (WebCore::ScriptExecutionContext::stopActiveDOMObjects):
> +	   * xml/XMLHttpRequest.cpp:
> +	   (WebCore::XMLHttpRequest::stop):
> +

Double change log here.

> +	   * http/tests/xmlhttprequest/abort-on-leaving-page-expected.txt:
Removed.
> +	   * http/tests/xmlhttprequest/abort-on-leaving-page.html: Removed.
> +	   * http/tests/xmlhttprequest/frame-load-cancelled-abort-expected.txt:

> +	   * http/tests/xmlhttprequest/resources/slow-response.pl: Removed.
> +	   Stopping an XHR due to navigation no longer dispatches events.

Was there any way to change these tests to verify the new behavior, rather than
removing them? Maybe that's pointless.

r=me