[webkit-reviews] review granted: [Bug 22673] Added support for the assertion (?=) and inverted assertion (?!) atoms in WREC. : [Attachment 25763] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted 's request for review:
Bug 22673: Added support for the assertion (?=) and inverted assertion (?!)
atoms in WREC.
https://bugs.webkit.org/show_bug.cgi?id=22673

Attachment 25763: patch
https://bugs.webkit.org/attachment.cgi?id=25763&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    switch (type) {
> +    case Generator::Assertion: {
> +	   m_generator.generateParenthesesAssertion(failures);
> +	   break;
> +    }
> +    case Generator::InvertedAssertion: {
> +	   m_generator.generateParenthesesInvertedAssertion(failures);
> +	   break;
> +    }
> +    default: {
> +	   m_error = UnsupportedParentheses;
> +	   return false;
> +    }
> +    }

We normally indent cases from the switch. We normally use braces for cases only
when they are needed.

> +    switch (q.type) {
> +    case Quantifier::None: {
> +	   return true;
> +    }
> +    case Quantifier::Greedy: {
> +	   m_error = UnsupportedParentheses;
> +	   return false;
> +    }
> +    case Quantifier::NonGreedy: {
> +	   m_error = UnsupportedParentheses;
> +	   return false;
> +    }
> +    case Quantifier::Error: {
> +	   return false;
> +    }
> +    }

Ditto.

r=me