[webkit-reviews] review granted: [Bug 22560] [GTK] Some Gtk Screen functions assume widgets are realized, leading to segfaults. : [Attachment 25605] Update to previous patch, fixing style mistakes.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 5 04:01:21 PST 2008


Holger Freyther <zecke at selfish.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 22560: [GTK] Some Gtk Screen functions assume widgets are realized, leading
to segfaults.
https://bugs.webkit.org/show_bug.cgi?id=22560

Attachment 25605: Update to previous patch, fixing style mistakes.
https://bugs.webkit.org/attachment.cgi?id=25605&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

> +	   Code in PlatformScreenGtk for screenDepth and screenRect can not

oh well, It can assume it. In fact the current code shows that it can assume
it. It should not assume the widget to be realized. :)



> +	   assume that the platformWindow for the widget has a valid "window" 
> +	   member.	For example in the case of, a new browser view opening
as a

remove bogus space when landing...


More information about the webkit-reviews mailing list