[webkit-reviews] review granted: [Bug 22671] Port the JIT to use the MacroAssembler, stage 1 of N. : [Attachment 25761] The patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 4 22:18:36 PST 2008


Geoffrey Garen <ggaren at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 22671: Port the JIT to use the MacroAssembler, stage 1 of N.
https://bugs.webkit.org/show_bug.cgi?id=22671

Attachment 25761: The patch
https://bugs.webkit.org/attachment.cgi?id=25761&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
r=me

Personally, I don't think we gain anything by changing things like "mov" and
"jo" in the assembler to "move" and "jover" in the macro assembler. I think
"jzSub32" and "joAdd32" are probably better names than "jzeroSub32" and
"joverAdd32."


More information about the webkit-reviews mailing list