[webkit-reviews] review granted: [Bug 22579] Avoid high-level WebCore types under platform : [Attachment 25757] New and improved! Now with const goodness and default implementation. Order now while supplies last!

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 4 17:07:31 PST 2008


Darin Adler <darin at apple.com> has granted Finnur Thorarinsson
<finnur.webkit at gmail.com>'s request for review:
Bug 22579: Avoid high-level WebCore types under platform
https://bugs.webkit.org/show_bug.cgi?id=22579

Attachment 25757: New and improved! Now with const goodness and default
implementation. Order now while supplies last!
https://bugs.webkit.org/attachment.cgi?id=25757&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> Index: WebCore/page/FrameView.h
> ===================================================================
> --- WebCore/page/FrameView.h	(revision 38997)
> +++ WebCore/page/FrameView.h	(working copy)
> @@ -30,6 +30,7 @@
>  #include "ScrollView.h"
>  #include <wtf/Forward.h>
>  #include <wtf/OwnPtr.h>
> +#include <wtf/Vector.h>

This include isn't needed because ScrollbarClient.h already includes Vector.h.

r=me


More information about the webkit-reviews mailing list