[webkit-reviews] review denied: [Bug 22656] tests document.write() : [Attachment 25746] patch for testing document.write

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 4 16:01:36 PST 2008

Darin Adler <darin at apple.com> has denied Danish Shrestha <krackguy at gmail.com>'s
request for review:
Bug 22656: tests document.write()

Attachment 25746: patch for testing document.write

------- Additional Comments from Darin Adler <darin at apple.com>
This test looks fine, but the patch needs to also include a ChangeLog entry.
Also, we prefer to have the "newline at end of file" unless there's a reason
not to have it.

Also, we prefer tests that cover a bit more per test. It's OK to have a test
that tests only this one targeted thing, but it's better to cover more per test
so our tests cover a lot of different cases and run quickly.

More information about the webkit-reviews mailing list