[webkit-reviews] review granted: [Bug 22579] Avoid high-level WebCore types under platform : [Attachment 25750] New patch, after addressing review comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 4 14:37:42 PST 2008


Darin Adler <darin at apple.com> has granted Finnur Thorarinsson
<finnur.webkit at gmail.com>'s request for review:
Bug 22579: Avoid high-level WebCore types under platform
https://bugs.webkit.org/show_bug.cgi?id=22579

Attachment 25750: New patch, after addressing review comments
https://bugs.webkit.org/attachment.cgi?id=25750&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
r=me as is.

But I have two comments. One is that this should probably be a const member
function, not non-const. The other is that maybe we should have a default empty
implementation in ScrollbarClient -- it seems unfortunate that all classes that
derive from this have to override it.


More information about the webkit-reviews mailing list