[webkit-reviews] review requested: [Bug 11850] Webarchive fails to save images referenced in CSS : [Attachment 25753] Pre-patch #2 v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 4 14:23:18 PST 2008

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 11850: Webarchive fails to save images referenced in CSS

Attachment 25753: Pre-patch #2 v1

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Proposed patch to clean up data structures used when collecting URLs of
subresources.  This fits much better when adding URLs within stylesheets (or
inline styles).

A couple of notes for reviewers:

- The change to WebCore::Node::getSubresourceURLs() removes the parseURL()
method from being called on most (if not all) subresource URL strings. 
However, this doesn't seem to be necessary for methods like

- WebCore::KURLHash::hash() in KURLHash.h was modified to handle "null" KURL
objects (which would otherwise cause a crash if you tried to add one to a

More information about the webkit-reviews mailing list