[webkit-reviews] review denied: [Bug 22631] Streamline Console.cpp, abstract out the use of JSC::ExecState and JSC::ArgList by introducing ScriptCallFrame and ScriptStackTrace abstractions : [Attachment 25714] ScriptCallFrame and ScriptStackTrace v1

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 22631: Streamline Console.cpp, abstract out the use of JSC::ExecState and
JSC::ArgList by introducing ScriptCallFrame and ScriptStackTrace abstractions
https://bugs.webkit.org/show_bug.cgi?id=22631

Attachment 25714: ScriptCallFrame and ScriptStackTrace v1
https://bugs.webkit.org/attachment.cgi?id=25714&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
This patch looks good. Though I think the ScriptCallFrame and ScriptStackFrame
classes are not clear.

I think more needs to be moved to ScriptStackFrame (like arguments, lineNumber
and sourceURL). Then call ScriptCallFrame ScriptCallStack, and make it only
return ScriptStackFrames. That would be a better design, and give more
functionality.

I like the CustomArgumentHandling changes and the Firebug compat
changes/comments!

r- based on the ScriptCallFrame and ScriptStackFrame classes design.