[webkit-reviews] review granted: [Bug 22609] Provide a build-time choice when generating hash tables for properties of built-in DOM objects : [Attachment 25694] Patch v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 22609: Provide a build-time choice when generating hash tables for
properties of built-in DOM objects
https://bugs.webkit.org/show_bug.cgi?id=22609

Attachment 25694: Patch v1
https://bugs.webkit.org/attachment.cgi?id=25694&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +#if ENABLE(PERFECT_HASH_SIZE)
>  void HashTable::createTable(JSGlobalData* globalData) const

Since both of these implementations share the same function name I think it
would be more elegant to put the #if around the body of the function rather
than the entire function.

> +// Define ENABLE_PERFECT_HASH_SIZE to 0 to save memory
> +#define ENABLE_PERFECT_HASH_SIZE 1

This is not a great comment. Why would anyone let the value be 1 if setting it
to 0 saves memory?

r=me