[webkit-reviews] review denied: [Bug 22648] Fix threading on Qt-port for Sampling tool : [Attachment 25739] fix waitForThreadCompletion for sampling tool

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 4 09:13:11 PST 2008


Darin Adler <darin at apple.com> has denied Gabor Loki <loki at inf.u-szeged.hu>'s
request for review:
Bug 22648: Fix threading on Qt-port for Sampling tool
https://bugs.webkit.org/show_bug.cgi?id=22648

Attachment 25739: fix waitForThreadCompletion for sampling tool
https://bugs.webkit.org/attachment.cgi?id=25739&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    if (result)
> +	   *result = g_thread_join(thread);

I believe this is wrong. Even if we don't want to store the result, we do want
to call g_thread_join so we wait for the thread to complete.


More information about the webkit-reviews mailing list