[webkit-reviews] review requested: [Bug 22105] Removing a media element from the document may trigger last second load() : [Attachment 25740] Patch with test case

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <tavestbo at trolltech.com> has asked  for review:
Bug 22105: Removing a media element from the document may trigger last second
load()
https://bugs.webkit.org/show_bug.cgi?id=22105

Attachment 25740: Patch with test case
https://bugs.webkit.org/attachment.cgi?id=25740&action=review

------- Additional Comments from Tor Arne Vestbø <tavestbo at trolltech.com>
Same check for networkState() != EMPTY but with test case. 

There's still a code path that can trigger this condition: if the element is
removed from the document while m_player is 0, but I'm not sure when that will
happen. 

We could guard for that too in removedFromDocument(), but would then miss out
on the timeupdateEvent and pauseEvent sent from pause() (if that's even a code
path we could hit). Any thoughts about this Antti?

Thanks!