[webkit-reviews] review granted: [Bug 22116] Revise manual charset alias in TextCodecICU : [Attachment 25723] updated patch (with more fleshed-out log entries)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 3 22:54:49 PST 2008

Alexey Proskuryakov <ap at webkit.org> has granted Jungshik Shin
<jshin at chromium.org>'s request for review:
Bug 22116: Revise manual charset alias in TextCodecICU

Attachment 25723: updated patch (with more fleshed-out log entries)

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> However, EUC-CN will not be picked up in the double-for-loop (going through
> IANA/MIME names and their aliases) because EUC-CN in convrtrs.txt is NOT
> with any standard.

According to online converter explorer, it has both MIME and IANA standard
names (GB2312 and csGB2312), so it should be picked. But I'm probably a little
confused: ChangeLog says "Maps 'EUC-CN' to 'GBK'", while I don't see any
changes to EUC-CN behavior in code, only an added test for it, which passes in

+// FIX: Have to add tests for Euro and a few new characters added to

We use FIXME for such comments.

All substantial changes look good, and this patch significantly cleans up code
and tests, r=me!

More information about the webkit-reviews mailing list