[webkit-reviews] review requested: [Bug 22620] Use ActiveDOMObject as base class for DOMTimers : [Attachment 25733] patch v5

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 3 19:33:44 PST 2008


Dmitry Titov <dimich at chromium.org> has asked  for review:
Bug 22620: Use ActiveDOMObject as base class for DOMTimers
https://bugs.webkit.org/show_bug.cgi?id=22620

Attachment 25733: patch v5
https://bugs.webkit.org/attachment.cgi?id=25733&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
Reflected the changes for bug 22630, created 2 tests (to be sent as separate
patch after a bit of cleanup), debugged through CachedPage suspense/resume and
debugger step. Browsed with debug bits. Seems good :-)

Hope someone familiar with timers/loading could take a look.


More information about the webkit-reviews mailing list