[webkit-reviews] review requested: [Bug 22577] Add a test to verify accessing INPUT elements with duplicate names : [Attachment 25722] Patch addressing Eric's comments in IRC

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 3 13:38:28 PST 2008


Pam Greene <pam at chromium.org> has asked  for review:
Bug 22577: Add a test to verify accessing INPUT elements with duplicate names
https://bugs.webkit.org/show_bug.cgi?id=22577

Attachment 25722: Patch addressing Eric's comments in IRC
https://bugs.webkit.org/attachment.cgi?id=25722&action=review

------- Additional Comments from Pam Greene <pam at chromium.org>
You can get to the list of elements with the same name either through
document.(form).(name) or document.getElementsByName(name).  Oddly, not only is
there no consistency in what object different browsers map the two access
methods to, but most don't even map the two to the same thing.

[browser: document.form.name and document.getElementsByName()]

Safari 3.2.1 and trunk: Collection and NodeList
Firefox 3.0.4: NodeList and HTMLCollection
Chrome 0.4.154.29: NodeList and NodeList
IE 6: object and object

Hard even to call that a bug, since nobody can be relying on it for anything
much.

So the test still checks only that whatever object they each map to has a
length property. I've also clarified the description and added
getElementsByName checks.


More information about the webkit-reviews mailing list