[webkit-reviews] review granted: [Bug 22623] Uninitialized memory access in cache parsing code : [Attachment 25707] Patch to initialize the variables in the contructors.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 3 06:32:50 PST 2008
David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Dean McNamee
<deanm at chromium.org>'s request for review:
Bug 22623: Uninitialized memory access in cache parsing code
https://bugs.webkit.org/show_bug.cgi?id=22623
Attachment 25707: Patch to initialize the variables in the contructors.
https://bugs.webkit.org/attachment.cgi?id=25707&action=review
------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
>+2008-12-03 Dean McNamee <deanm at chromium.org>
>+
>+ Reviewed by NOBODY (OOPS!).
>+
>+ Initialize m_haveParsedCacheControlHeader and
m_haveParsedPragmaHeader.
>+
>+ * platform/network/ResourceResponseBase.h:
>+ (WebCore::ResourceResponseBase::ResourceResponseBase):
Please include a reference to this bug in the ChangeLog entry before landing
the patch.
Otherwise, looks good. Thanks for finding this! r=me
More information about the webkit-reviews
mailing list