[webkit-reviews] review denied: [Bug 22580] canvas.setShadow should use platform-independent GraphicsContext API : [Attachment 25698] [1/1] Convert CanvasRenderingContext2D::setShadow to use

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 2 21:23:24 PST 2008


mitz at webkit.org has denied Tony Chang (Google) <tony at chromium.org>'s request
for review:
Bug 22580: canvas.setShadow should use platform-independent GraphicsContext API
https://bugs.webkit.org/show_bug.cgi?id=22580

Attachment 25698: [1/1] Convert CanvasRenderingContext2D::setShadow to use
https://bugs.webkit.org/attachment.cgi?id=25698&action=review

------- Additional Comments from mitz at webkit.org
The patch is missing a change log entry. I think the test is redundant, because
fast/transforms/shadows.html covers that case as well as several other. Given
the expected usage pattern, do you think it will make more sense to make the
shadow behavior part of the graphics state, so that canvas can just set it once
when it creates the context?


More information about the webkit-reviews mailing list